Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(participant): add handling for token cancellation, pass to docs fetch request, remove unused abort controllers #831

Merged
merged 3 commits into from
Sep 24, 2024
Merged

chore(participant): add handling for token cancellation, pass to docs fetch request, remove unused abort controllers #831

merged 3 commits into from
Sep 24, 2024

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 23, 2024

We want to fail early and not ping the model when the chat token's token is cancelled.

This pr:

  • Adds more places for us to fail early when the token is cancelled.
  • Adds an abort signal to the docs ai requests.
  • Removes 3 unused abort controllers we had.

nirinchev
nirinchev approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks good.

src/participant/docsChatbotAIService.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
src/participant/participant.ts Outdated Show resolved Hide resolved
@Anemy Anemy merged commit 65830fa into VSCODE-528-mongodb-copilot Sep 24, 2024
3 checks passed
@Anemy Anemy deleted the remove-unused-abort-controllers branch September 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenakhineika alenakhineika alenakhineika approved these changes

@nirinchev nirinchev nirinchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anemy @nirinchev @alenakhineika