chore(participant): add progress indicators for asynchronous requests in chat VSCODE-613 #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| stream.push( | ||
| new vscode.ChatResponseProgressPart('Fetching database names...') |
There was a problem hiding this comment.
So does the progress bar disappear as soon as we call stream.markdown or a similar output method?
alenakhineika
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-613
The only thing we don't show an in progress for is now when we're connecting. This would require a refactoring of how we do the connecting flow, it currently now happens outside of a chat response, and once the connection happens we then enter a chat. We might want to do that, I'll bring it up with y'all in slack. I'm thinking it can land in a separate pr.
Included some drive-by log error additions as well as removing unintended tabs in our welcome message.