fix: cannot find module electron VSCODE-598 #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Aug 30, 2024
alenakhineika
added a commit
that referenced
this pull request
Sep 2, 2024
* chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784) * feat: show survey VSCODE-562 (#780) --------- Co-authored-by: Rhys <[email protected]> Co-authored-by: Rhys Howell <[email protected]> * fix: add telemetry events for survey VSCODE-595 (#787) * fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789) * fix(deps): bump shell and data-service deps VSCODE-564 (#794) * fix: clean-up webpack config VSCODE-597 (#795) * Update changelog (#796) Co-authored-by: mcasimir <[email protected]> * Update changelog (#797) Co-authored-by: alenakhineika <[email protected]> * fix: cannot find module electron VSCODE-598 (#799) * Update changelog (#801) Co-authored-by: mcasimir <[email protected]> * Update changelog (#802) Co-authored-by: alenakhineika <[email protected]> --------- Co-authored-by: Rhys <[email protected]> Co-authored-by: Paula Stachova <[email protected]> Co-authored-by: Rhys Howell <[email protected]> Co-authored-by: Anna Henningsen <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mcasimir <[email protected]>
nirinchev
added a commit
that referenced
this pull request
Sep 10, 2024
* main: chore(ci): Update deprecated github actions (#813) Update changelog (#802) Update changelog (#801) fix: cannot find module electron VSCODE-598 (#799) Update changelog (#797) Update changelog (#796) fix: clean-up webpack config VSCODE-597 (#795) fix(deps): bump shell and data-service deps VSCODE-564 (#794) fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789) fix: add telemetry events for survey VSCODE-595 (#787) feat: show survey VSCODE-562 (#780) chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use empty import for
electronandhadron-ipcinstead of import as externals.Checklist
Motivation and Context
Types of changes