Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump micromatch VSCODE-533 VSCODE-534 #737

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Jun 3, 2024

Checklist

Motivation and Context

https://jira.mongodb.org/browse/VSCODE-533
https://jira.mongodb.org/browse/VSCODE-534

Updating micromatch also updates braces to 3.0.3, which includes the fix for the SNYK-JS-BRACES-6838727 vulnerability https://github.com/micromatch/braces/commits/master/. This leaves only jest, which is a dev dependency so hopefully the vulnerability is not applicable. (I checked if updating jest is easy, but we are several major versions behind so it's a rabbit hole).

Screenshot 2024-06-03 at 15 56 28

I couldn't find the release notes for micromatch, but the description of SNYK-JS-MICROMATCH-6838728 said it already had the fix on main. that was from 2 weeks ago, the latest version is 12 days ago 🤷
https://github.com/micromatch/micromatch/commits/master/

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho merged commit dcf97f7 into main Jun 3, 2024
5 checks passed
@paula-stacho paula-stacho deleted the VSCODE-533 branch June 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants