Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playground): add support local require VSCODE-468 #718

Merged
merged 3 commits into from
Apr 17, 2024
Merged

feat(playground): add support local require VSCODE-468 #718

merged 3 commits into from
Apr 17, 2024

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Apr 11, 2024 •
edited by alenakhineika
Loading

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

addaleax
addaleax reviewed Apr 11, 2024
View reviewed changes
src/language/worker.ts Outdated Show resolved Hide resolved
src/language/worker.ts Outdated Show resolved Hide resolved
src/language/worker.ts Outdated Show resolved Hide resolved
@mabaasit mabaasit marked this pull request as ready for review April 12, 2024 14:36
alenakhineika
alenakhineika approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Super handy feature and really wanted by users of the extension ✨ The code also looks good 👍

addaleax
addaleax approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add a test for this?

@mabaasit mabaasit merged commit 0390097 into main Apr 17, 2024
5 checks passed
@mabaasit mabaasit deleted the VSCODE-468-local-require branch April 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenakhineika alenakhineika alenakhineika approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabaasit @addaleax @alenakhineika