Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show simpler uuid format VSCODE-470 #701

Merged
merged 9 commits into from
Mar 13, 2024
Merged

feat: show simpler uuid format VSCODE-470 #701

merged 9 commits into from
Mar 13, 2024

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Mar 6, 2024

https://jira.mongodb.org/browse/VSCODE-470

Description

Adding postprocessing in the Document Service, which replaces the extended $binary notation with $uuid notation when presenting the document. Originally I thought we should reverse this on replaceDocument, but it looks like this is not necessary - I assume this is handled by the driver. I left the test case for regression, but perhaps it's not necessary.

Aside of the new tests, I have tested this with the all_types collection of compass-data-sets/test. I added a couple of new fields to the first document - nested_uuid and nested_array_uuid
I tried

  • opening a document from the left side panel
  • playground results for findOne()
  • playground results for find()

Checklist

  • New tests and/or benchmarks are included

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

src/editors/mongoDBDocumentService.ts Outdated Show resolved Hide resolved
src/editors/mongoDBDocumentService.ts Outdated Show resolved Hide resolved
@paula-stacho paula-stacho marked this pull request as ready for review March 7, 2024 16:54
src/utils/ejson.ts Outdated Show resolved Hide resolved
src/utils/ejson.ts Outdated Show resolved Hide resolved
src/utils/ejson.ts Outdated Show resolved Hide resolved
src/utils/ejson.ts Outdated Show resolved Hide resolved
src/utils/ejson.ts Outdated Show resolved Hide resolved
@paula-stacho paula-stacho merged commit 10f4267 into main Mar 13, 2024
5 checks passed
@paula-stacho paula-stacho deleted the VSCODE-470 branch March 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants