Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure extension output populates ObjectIds in stream #657

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

pulkitkalra-mdb
Copy link
Contributor

@pulkitkalra-mdb pulkitkalra-mdb commented Jan 12, 2024

VSCODE-511

Description

The console output from the extension wasn't returning the correct representations for ObjectIds so they weren't being printed.

This PR udpates the worker to perform the evaluation of the payload as a string before passing it to the listener to print.

@pulkitkalra-mdb pulkitkalra-mdb marked this pull request as ready for review January 15, 2024 00:03
task: add assertion for objectId to unit test
@pulkitkalra-mdb pulkitkalra-mdb merged commit ac1a000 into main Jan 15, 2024
5 checks passed
@pulkitkalra-mdb pulkitkalra-mdb deleted the VSCODE-511 branch January 15, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants