chore(connections): remove keytar, keytar migration, and connection model migration VSCODE-499 #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
reviewed
Dec 13, 2023
| @@ -32,9 +32,12 @@ export type ConnectionsFromStorage = { | |||
| [connectionId: string]: StoreConnectionInfo; | |||
| }; | |||
|
|
|||
| // Keytar is deprecated and no longer used. All new | |||
| // connections use 'SecretStorage'. | |||
There was a problem hiding this comment.
can't we just delete this?
There was a problem hiding this comment.
The other values here could still be on someone's stored connection if they open vscode for the first time in 5 months, I reckon we can remove these types but we should still account for when the secretStorageLocation isn't SecretStorage. Leaving these on the type I thought might give more insight into how it can be different. Do you prefer it deleted? I'm cool with either.
addaleax
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-499
Removes the keytar migration and the connection model migration we previously had. For anyone who didn't open the extension in the last ~5 months with the migration they will lose their saved connections. Double checked with Gaurab, he gave the ok.