feat(webview): use Compass' connection form in the new overview page VSCODE-488 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
himanshusinghs
approved these changes
Dec 7, 2023
Co-authored-by: Himanshu Singh <[email protected]>
Anemy
commented
Dec 8, 2023
| @@ -12,7 +12,7 @@ const vsixFileName = path.resolve( | |||
| ); | |||
| const size = fs.statSync(vsixFileName).size; | |||
|
|
|||
| const maxSize = 7 * 1000000; // 7 MB | |||
| const maxSize = 8 * 1000000; // 8 MB | |||
There was a problem hiding this comment.
This isn't a great thing to increase, going to investigate in a follow up what's driving it up. (This pr increases it ~1mb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-488
Feature flagged. Adds the connection-form from Compass to the webview.
Going to sync with design on if we want the modal content to scroll here. Shouldn't be a blocker for this as it would be purely visual, and this will unblock some other work in the project.