chore(playground): codelens for active connection will inform about default connected database VSCODE-316 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
commented
Dec 5, 2023
Comment on lines
-1311
to
-1329
| test('provide collection names completion for valid object names', async () => { | ||
| const content = 'use("test"); db.'; | ||
| const position = { line: 0, character: 16 }; | ||
| const document = TextDocument.create('init', 'javascript', 1, content); | ||
|
|
||
| testMongoDBService._cacheCollections('test', [{ name: 'empty' }]); | ||
|
|
||
| const result = await testMongoDBService.provideCompletionItems({ | ||
| document, | ||
| position, | ||
| }); | ||
| const findCollectionCompletion = result.find( | ||
| (item: CompletionItem) => item.label === 'empty' | ||
| ); | ||
| expect(findCollectionCompletion).to.have.property( | ||
| 'kind', | ||
| CompletionItemKind.Folder | ||
| ); | ||
| }); |
There was a problem hiding this comment.
All these tests (collection names completion tests) are not removed. I just moved them in a dynamic suite to test three different scenarios.
Anemy
approved these changes
Dec 5, 2023
himanshusinghs
force-pushed
the
VSCODE-316-playgrounds-provide-default-db-info
branch
from
16033ac to
cda24a9
Compare
alenakhineika
approved these changes
Dec 6, 2023
Co-authored-by: Alena Khineika <[email protected]>
himanshusinghs
deleted the
VSCODE-316-playgrounds-provide-default-db-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original issue highlighted in VSCODE-316 (playground should run in database specified in connection string), is not reproducible anymore. It works as expected - if no
use('database')call is specified in playground and there is a database specified in connection string then the playground will run in the database specified in connection string.With this PR, we will now additionally highlight, in the playground, the default database that the playground will run in, if there is one specified in connection string.
mongodb+srv://<credentials>@hostmongodb+srv://<credentials>@host/countriesWe additionally also provide autocomplete for the collection names on the
dbobject when connected using a connection string with default database and there is no explicituse('DB')call in the playground.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes