Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable Saved Connections Loaded event #585

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: disable Saved Connections Loaded event #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/connectionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ export default class ConnectionController {
this.eventEmitter.emit(DataServiceEventTypes.CONNECTIONS_DID_CHANGE);
}

this._telemetryService.trackSavedConnectionsLoaded({
// TODO: re-enable with fewer 'Saved Connections Loaded' events
// https://jira.mongodb.org/browse/VSCODE-462
/* this._telemetryService.trackSavedConnectionsLoaded({
saved_connections: globalAndWorkspaceConnections.length,
loaded_connections: loadedConnections.length,
connections_with_secrets_in_keytar: loadedConnections.filter(
Expand All @@ -234,7 +236,7 @@ export default class ConnectionController {
connection.secretStorageLocation ===
SecretStorageLocation.SecretStorage
).length,
});
}); */

if (connectionsThatDidNotMigrate.length) {
log.error(
Expand Down
2 changes: 1 addition & 1 deletion src/test/suite/connectionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,7 +1762,7 @@ suite('Connection Controller Test Suite', function () {
assert.strictEqual(trackStub.notCalled, true);
});

test('should track SAVED_CONNECTIONS_LOADED event on load of saved connections', async () => {
test.skip('should track SAVED_CONNECTIONS_LOADED event on load of saved connections', async () => {
testSandbox.replace(testStorageController, 'get', (key, storage) => {
if (
storage === StorageLocation.WORKSPACE ||
Expand Down
2 changes: 1 addition & 1 deletion src/test/suite/telemetry/telemetryService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ suite('Telemetry Controller Test Suite', () => {
});
});

test('track saved connections loaded', () => {
test.skip('track saved connections loaded', () => {
testTelemetryService.trackSavedConnectionsLoaded({
saved_connections: 3,
loaded_connections: 3,
Expand Down