Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adopt dns result order changes VSCODE-458 #575

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 8, 2023

Description

Adopt dns result order changes with Node v18 and vscode 1.82.0-insider update to resolve:

stack trace: Error: Request ACTIVE_CONNECTION_CHANGED failed with message: connect ECONNREFUSED ::1:27018
	at handleResponse (/Users/alena.khineika/www/vscode/node_modules/vscode-jsonrpc/lib/common/connection.js:565:48)
	at handleMessage (/Users/alena.khineika/www/vscode/node_modules/vscode-jsonrpc/lib/common/connection.js:345:13)
	at processMessageQueue (/Users/alena.khineika/www/vscode/node_modules/vscode-jsonrpc/lib/common/connection.js:362:17)
	at Immediate.<anonymous> (/Users/alena.khineika/www/vscode/node_modules/vscode-jsonrpc/lib/common/connection.js:334:13)
	at process.processImmediate (node:internal/timers:476:21)

The vscode provides a fix for the extension host, but we also need to add this for LS and workers.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Dependents

Related tp: microsoft/vscode#189805

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from mcasimir August 8, 2023 19:09
@alenakhineika alenakhineika merged commit 3f52d05 into main Aug 10, 2023
@alenakhineika alenakhineika deleted the VSCODE-458-adopt-dns-result-order-changes branch August 10, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants