Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Export to Go support VSCODE-411 #567

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

GaurabAryal
Copy link
Contributor

Description

Exposes "Export to GO" support.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@@ -243,6 +243,10 @@
"command": "mdb.exportToRuby",
"title": "MongoDB: Export To Ruby"
},
{
"command": "mdb.exportToGo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also specify that this command is available only when a user is connected and for playground only and not other files opened in vscode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what Alena mentioned, I would only request a small change in PR title, for it to be aligned with the guideline here. Helps creating better, semantically readable release notes towards the end when we do the releases.

@GaurabAryal GaurabAryal changed the title FEAT: VSCODE-411 (only GO support) Added export to Go support feat: Added Export to Go support VSCODE-411 Jul 21, 2023
@GaurabAryal GaurabAryal changed the title feat: Added Export to Go support VSCODE-411 feat: added Export to Go support VSCODE-411 Jul 21, 2023
@GaurabAryal GaurabAryal merged commit 3593f6c into main Jul 27, 2023
@GaurabAryal GaurabAryal deleted the VSCODE-411-GO branch July 27, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants