refactor: simplify constructor argument assignment VSCODE-441 #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jul 4, 2023
addaleax
approved these changes
Jul 4, 2023
src/test/suite/editors/activeConnectionCodeLensProvider.test.ts
Outdated
Show resolved
Hide resolved
|
Was it something particular that was causing troubles to you that you decided to do this massive refactoring? |
It was sitting with Himanshu looking at the the extension's code for the connectivity improvements that got me wanting to start improving the code quality here. Not really a good product reason 😆 . Sorry it's a large code diff out of the blue. Haven't really been in this code base for a while so I was thinking it'll be nice for the future if things are easier to work with, I introduced a lot of the wonky code practices in this project. |
alenakhineika
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-441
In a good number of classes in the extension's source we pass a lot of arguments in the constructors. To make things easier to refactor and reason about, this pr updates those classes instead pass an object we deconstruct in these places.
A bit of drive-by test cleanup and refactoring as well with the goal of making things simpler. Still a whole lot we could do here, this should help a bit.