Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable playground loaded event VSCODE-432 #545

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: disable playground loaded event VSCODE-432 #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/editors/playgroundController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,11 @@ export default class PlaygroundController {

vscode.workspace.onDidOpenTextDocument(async (document) => {
if (isPlayground(document.uri)) {
this._telemetryService.trackPlaygroundLoaded(
// TODO: re-enable with fewer 'Playground Loaded' events
// https://jira.mongodb.org/browse/VSCODE-432
/* this._telemetryService.trackPlaygroundLoaded(
getPlaygroundExtensionForTelemetry(document.uri)
);
); */
await vscode.languages.setTextDocumentLanguage(document, 'javascript');
}
});
Expand Down
5 changes: 3 additions & 2 deletions src/test/suite/telemetry/telemetryService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ suite('Telemetry Controller Test Suite', () => {
);
});

test('track mongodb playground loaded event', async () => {
// TODO: re-enable two tests after https://jira.mongodb.org/browse/VSCODE-432
test.skip('track mongodb playground loaded event', async () => {
const docPath = path.resolve(
__dirname,
'../../../../src/test/fixture/testSaving.mongodb'
Expand All @@ -266,7 +267,7 @@ suite('Telemetry Controller Test Suite', () => {
);
});

test('track mongodbjs playground loaded event', async () => {
test.skip('track mongodbjs playground loaded event', async () => {
const docPath = path.resolve(
__dirname,
'../../../../src/test/fixture/testSaving.mongodb.js'
Expand Down