refactor: clean up #512
Merged
refactor: clean up #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
commented
Apr 14, 2023
| { scheme: 'untitled', language: 'javascript' }, | ||
| { scheme: 'file', language: 'javascript' }, | ||
| { pattern: '**/*.mongodb.js' }, | ||
| { pattern: '**/*.mongodb' }, |
There was a problem hiding this comment.
Register language server only for playgrounds.
alenakhineika
commented
Apr 14, 2023
| @@ -88,6 +88,9 @@ export default class LanguageServerController { | |||
| } | |||
|
|
|||
| async startLanguageServer(): Promise<void> { | |||
| // Start the client. This will also launch the server. | |||
| await this._client.start(); | |||
There was a problem hiding this comment.
I do not see a difference in behavior between having or skipping this step. But to be on the safer side let's have it as it is in vscode examples.
alenakhineika
commented
Apr 14, 2023
| } | ||
|
|
||
| // Stop the language server. | ||
| return this._client.stop(); |
There was a problem hiding this comment.
Also aligement with vscode examples.
alenakhineika
commented
Apr 14, 2023
src/language/visitor.ts
Outdated
| export class Visitor { | ||
| _state: CompletionState; | ||
| _state: CompletionState | ExportToLanguageState | {}; |
There was a problem hiding this comment.
For better debugging, use separate states for different use cases to better understand what parameters affect the behavior.
addaleax
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts refactoring, that was done as part of the TypeScript service investigation PR. We removed help signatures out of the Efficient Query Development in VSCode epic, but some clean up can be merged separately here.
Checklist
Motivation and Context
Types of changes