fix(tree-explorer): use nameOnly for fetching databases VSCODE-361 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use the database here so passing
nameOnlyshould give a speedup.Part of VSCODE-361
This also fixes an issue where the database names aren't showing for free tier instances (or maybe specific admin roles). Haven't gotten to the exact cause yet. We're using the
listDatabaseswith fallbacks for roles/privileges from Compass: https://github.com/mongodb-js/compass/blob/4e06bd332f20c122730e204e7d379b9cd1656767/packages/data-service/src/data-service.ts#L1039