-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to latest mongosh, driver, and segment analytics VSCODE-366 #494
feat: update to latest mongosh, driver, and segment analytics VSCODE-366 #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, left a question and a comment on _id types that might not be ObjectId
s.
@@ -16,6 +16,9 @@ const baseConfig = { | |||
|
|||
const extensionConfig = { | |||
...baseConfig, | |||
experiments: { | |||
topLevelAwait: true, | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this anywhere? What's the motivation for this change? I'm just curious, looks good either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something changed in the bson
library I believe that requires a top-level await, so the extension crashed on startup with the error:
2023-03-20 18:06:02.608 [error] Activating extension mongodb.mongodb-vscode failed due to an error:
2023-03-20 18:06:02.608 [error] Error: Module parse failed: The top-level-await experiment is not enabled (set experiments.topLevelAwait: true to enabled it)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
Error: The top-level-await experiment is not enabled (set experiments.topLevelAwait: true to enabled it)
at /Users/alena.khineika/www/vscode/node_modules/webpack/lib/dependencies/HarmonyDetectionParserPlugin.js:54:11
at Hook.eval [as call] (eval at create (/Users/alena.khineika/www/vscode/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:16)
...
at ./node_modules/bson/lib/bson.mjs (/Users/alena.khineika/www/vscode/dist/extension.js:90406:7)
at __webpack_require__ (/Users/alena.khineika/www/vscode/dist/extension.js:336777:43)
Description
Update to:
Checklist
Motivation and Context
Types of changes