Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playground): adds new Time-Series options for collection creation in playgrounds VSCODE-362 #478

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat(playground): adds new Time-Series options for collection creation in playgrounds VSCODE-362 #478

merged 1 commit into from
Feb 14, 2023

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Feb 14, 2023 •
edited
Loading

Description

VSCODE-362

This PR adds new options (bucketMaxSpanSeconds and bucketRoundingSeconds), introduced in MongoDB 6.3, to time-series collection options in create-collection playground template.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Anemy
Anemy approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@himanshusinghs himanshusinghs merged commit 8498830 into main Feb 14, 2023
@himanshusinghs himanshusinghs deleted the VSCODE-362-new-timeseries-options branch February 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenakhineika alenakhineika alenakhineika approved these changes

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himanshusinghs @Anemy @alenakhineika