Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: get rid of eslint warnings #475

Merged
merged 2 commits into from
Feb 8, 2023
Merged

chore: get rid of eslint warnings #475

merged 2 commits into from
Feb 8, 2023

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Feb 8, 2023 

/Users/rhys/mongodb/vscode/src/telemetry/telemetryService.ts
  133:29  warning  Unexpected sync method: 'readFileSync'  no-sync

/Users/rhys/mongodb/vscode/src/test/suite/language/languageServerController.test.ts
  137:12  warning  Unexpected sync method: 'existsSync'  no-sync

/Users/rhys/mongodb/vscode/src/test/suite/language/mongoDBService.test.ts
  38:12  warning  Unexpected sync method: 'existsSync'  no-sync

addaleax
addaleax approved these changes Feb 8, 2023
View reviewed changes
src/telemetry/telemetryService.ts Outdated Show resolved Hide resolved
@Anemy Anemy merged commit 2ac309b into main Feb 8, 2023
@Anemy Anemy deleted the fix-eslint-warnings branch February 8, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anemy @addaleax