Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tree-explorer): add delete document context menu item VSCODE-349 #452

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Nov 30, 2022

VSCODE-349

This adds a setting confirmDeleteDocument which defaults true to show a confirmation when deleting a document. Can add more tests if folks would like that.

Delete.doc.from.tree.view.mp4

@alenakhineika
Copy link
Contributor

Would it make sense to have this setting not only for deleting documents but for any deleting operation? I am wondering how often users expect a different confirmation behaviour for different entities.

@Anemy
Copy link
Member Author

Anemy commented Dec 5, 2022

@alenakhineika good question, I was thinking that having this setting only for deleting documents makes sense as its most likely something that folks do more often in their development. I don't see dropping a database or collection happening often enough to warrant sharing a setting or having separate settings for each. Are there other delete behaviors you were thinking of?

@Anemy Anemy merged commit 2fed1fd into main Dec 7, 2022
@Anemy Anemy deleted the VSCODE-349-delete-document-actions branch December 7, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants