Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make mongodb-client-encryption optional VSCODE-342 #439

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Sep 22, 2022

Description

  • Bump the mongodb-data-service version that makes the mongodb-client-encryption module optional. That will ensure that VSCode extension builds are OS-independent.
  • Add the compass-preferences-model module to webpack externals because it is now an optional dependency of @mongodb-js/compass-logging and otherwise causes the Can't resolve 'compass-preferences-model' error.
  • Replace output.libraryTarget with output.library.type since webpack might drop support for output.libraryTarget in the future.
  • Use commonjs output type since commonjs2 is not a thing anymore and probably anyway aliases to commonjs.
  • Use the proper os-dns-native module name instead of underscores.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax
Copy link
Contributor

In the ticket, I made the suggestion to use npm install --omit=optional – did you look into that? I think that might be a good way to help catch these issues ahead of time in the future.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@alenakhineika alenakhineika merged commit 8451066 into main Sep 26, 2022
@alenakhineika alenakhineika deleted the VSCODE-342-optional-mongodb-client-encryption branch September 26, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants