feat: make mongodb-client-encryption optional VSCODE-342 #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mongodb-data-service
version that makes themongodb-client-encryption
module optional. That will ensure that VSCode extension builds are OS-independent.compass-preferences-model
module to webpack externals because it is now an optional dependency of@mongodb-js/compass-logging
and otherwise causes theCan't resolve 'compass-preferences-model'
error.output.library.type
since webpack might drop support foroutput.libraryTarget
in the future.commonjs
output type sincecommonjs2
is not a thing anymore and probably anyway aliases tocommonjs
.os-dns-native
module name instead of underscores.Checklist
Motivation and Context
Types of changes