feat(playground): Add clusteredIndex option to createCollection playground template VSCODE-330
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me-series template and combine
lerouxb
reviewed
Apr 27, 2022
| granularity: <string> | ||
| }, | ||
| expireAfterSeconds: <number>, | ||
| clusteredIndex: <document>, // Added in MongoDB 5.3 |
There was a problem hiding this comment.
I see for timeseries we list some options but for clusteredIndex and a few others we just say <document>. Wondering if we should put more stuff in there? Maybe best like this so they have to read the documentation.
There was a problem hiding this comment.
We're following the docs there: https://www.mongodb.com/docs/v5.3/reference/method/db.createCollection/
Which also only expands the time-series document. I'm not totally sure on the reasoning there. I think it's alright though, since these are more complex configurations I think expanding all of them might make us have to update this more frequently, and could possibly lead some users astray on differing mongodb server versions.
Anemy
deleted the
VSCODE-330-add-clustered-index-option-to-create-collection-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-330
This pr adds the
clusteredIndexoption to thecreateCollectionplayground template. This template is opened when a user clicks to create a new database or collection.This pr also changes the behavior around where we would previously show the
time-seriescollection creation configuration. Previously we had a separate template with these options more isolated, this pr removes the extra template and instead adds all of the options to one template.Since there are some behavioral changes I'm going to sync with Max before we merge this. I think we wantedSynced w/ Max, he's cool with removing the version gate on showing this feature.time-seriescollections to be hidden until world in the past, however I think this had the side effect that after world, users on earlier MongoDB versions would not see thattime-seriescollections are a thing and they might want to upgrade/investigate.I opted to always show the two with a comment about the required version. I was aiming to bring it inline with the template provided in the documentation: https://www.mongodb.com/docs/v5.3/reference/method/db.createCollection/
We're also adding a link to the
createCollectiondocumentation in the template forcreateCollectionin this pr.updated.create.collection.tempalte.vscode.mp4