feat(connect): use extracted connection logic from mongosh MONGOSH-1080

[alenakhineika]

Description

• Bump the data-service version to start using extracted connection logic from mongosh.
• Refactor connection controller to keep original stack trace while throwing errors.
• Improve formatting error messages.
• Remove connection-model from dependencies.
• Set setting strictModuleExceptionHandling: true because by default it false: https://webpack.js.org/configuration/output/#outputstrictmoduleerrorhandling. We need devtools-connect throw the error if can not resolve os-dns-native: https://github.com/mongodb-js/devtools-connect/blob/main/src/connect.ts#L91.

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[addaleax]

If you want to check whether something is a built-in Error object, this is better:

Suggested change

	if (err instanceof Error) {
	if (Object.prototype.toString.call(err) === '[object Error]') {

since instanceof is not a reliable brand check in JS:

> vm.runInNewContext('new Error("banana")')
Error: banana
    at evalmachine.<anonymous>:1:1
    [… rest of stack …]
> vm.runInNewContext('new Error("banana")') instanceof Error
false

or alternatively I’d be more specific and just test whether the actual properties you’re looking for are present:

Suggested change

	if (err instanceof Error) {
	if (typeof err?.name === 'string' && typeof err?.message === 'string' && typeof err?.stack === 'string') {

[alenakhineika]

nice!! thank you for the suggestion! ❤️