Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export to language connect and telemetry VSCODE-318, VSCODE-322 #386

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Feb 2, 2022

Description

  • VSCODE-322 Users should be able to benefit from the Export to language feature even if they are not connected to a cluster. Some languages might use details from the active connection to build a connection string and use it inside driver syntax, use a placeholder string in such cases.
  • VSCODE-318 Add telemetry to understand the success of Export to language in VSCode.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

};
if (driverSyntax) {
const connectionId = this._connectionController.getActiveConnectionId();
let driverUrl = 'mongodb://localhost:27017';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn’t we need this before? I’m sure there is a reason, it’s just not obvious to me :)

Copy link
Contributor Author

@alenakhineika alenakhineika Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because before we didn't support export to language for a disconnected state. And now we just use this string as default and database and collection placeholders, so users can still get exported results and then replace it with whatever they want. And for the connected state, there was always a real URL from the current connection.

@alenakhineika alenakhineika merged commit 3e5424c into main Feb 7, 2022
@alenakhineika alenakhineika deleted the export-to-language-connect-and-telemetry branch February 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants