refactor: apply tell-don’t-ask principle #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Dec 1, 2021
| ) { | ||
| return true; | ||
| this._state.isCollectionName = true; |
There was a problem hiding this comment.
Are these variables ever unset or set to false?
There was a problem hiding this comment.
Yeah, they all are being reset with each parse of the file:
https://github.com/mongodb-js/vscode/blob/apply-tell-do-not-ask-principle/src/language/visitor.ts#L141
Anemy
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce complexity and improve code readability by applying Tell-Don’t-Ask refactoring principle: instead of asking an object about its state and then performing actions based on this, it’s much easier to simply tell the object what it needs to do and let it decide for itself how to do that.
Checklist
Motivation and Context
Types of changes