fix(language-server): remove loading ssl/tls files to just passing file names VSCODE-292 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-292
PR removes loading the files of tls/ssl files. Now we just pass the file names. I think we were doing this because of previous driver behavior, after we updated the driver in the latest release this probably broke.
Tested on mac w/ server+client and x509
Before releasing we should make sure we have this in the testing matrix and test it (I must have missed in it in the last release).
We could probably add some nice e2e connectivity tests w/ playgrounds following the current Compass work.
Connecting + running a playground:
