Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect-form): fix wsl file path resolving VSCODE-284 #343

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 1, 2021

VSCODE-284

Fixes opening files on wsl. Remove the resolving of the file path, since it's resolved later. Not sure why we were doing it, looks like something I introduced lol. Maybe it was needed for the connection model & driver at the time.

Tested manually on wsl & mac w/ a tls file.

nwKrF1vDmE.mp4

@Anemy Anemy requested a review from alenakhineika September 23, 2021 14:37
@Anemy Anemy merged commit 55a5fa2 into main Sep 28, 2021
@Anemy Anemy deleted the fix-wsl-fix-resolve branch September 28, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant