VSCODE-247: Replace code lenses with code actions #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
force-pushed
the
VSCODE-247-replace-code-lenses-with-code-actions
branch
from
4d38634 to
14ad445
Compare
alenakhineika
force-pushed
the
VSCODE-247-replace-code-lenses-with-code-actions
branch
from
14ad445 to
b7fdfc9
Compare
addaleax
approved these changes
Aug 12, 2021
| @@ -18,5 +18,6 @@ | |||
| "other": true, | |||
| "comments": false, | |||
| "strings": true | |||
| } | |||
| }, | |||
| "security.workspace.trust.enabled": false | |||
There was a problem hiding this comment.
This is an unrelated change, right?
There was a problem hiding this comment.
Vscode 1.57 introduced a trusted authors confirmation modal, that interrupts tests, so this line disables this check during tests running.
| expect(codeActions).to.be.undefined; | ||
| }); | ||
|
|
||
| test('expected provideCodeActions to return a run selected playground blocks action', () => { |
There was a problem hiding this comment.
Would it be possible to add a test that actually runs the selected code? As far as I can tell, there wasn’t any before, but it might be a nice thing to have here
alenakhineika
deleted the
VSCODE-247-replace-code-lenses-with-code-actions
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Types of changes