chore: use consistent type imports VSCODE-410 (#579)

.eslintrc.js

@@ -59,6 +59,10 @@ module.exports = {
         '@typescript-eslint/no-unsafe-call': 0,
         '@typescript-eslint/no-unsafe-return': 0,
         '@typescript-eslint/no-unsafe-argument': 0,
+        '@typescript-eslint/consistent-type-imports': [
+          'error',
+          { prefer: 'type-imports' },
+        ],
       },
       parserOptions: {
         project: ['./tsconfig.json'], // Specify it only for TypeScript files.

src/commands/launchMongoShell.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 
 const launchMongoDBShellWithEnv = (
   shellCommand: string,

src/connectionController.ts

@@ -1,14 +1,16 @@
 import * as vscode from 'vscode';
 import {
   convertConnectionModelToInfo,
-  ConnectionInfo,
-  ConnectionOptions,
   getConnectionTitle,
   extractSecrets,
   mergeSecrets,
   connect,
 } from 'mongodb-data-service';
-import type { DataService } from 'mongodb-data-service';
+import type {
+  DataService,
+  ConnectionInfo,
+  ConnectionOptions,
+} from 'mongodb-data-service';
 import ConnectionString from 'mongodb-connection-string-url';
 import { EventEmitter } from 'events';
 import type { MongoClientOptions } from 'mongodb';
@@ -18,15 +20,16 @@ import { CONNECTION_STATUS } from './views/webview-app/extension-app-message-con
 import { createLogger } from './logging';
 import { ext } from './extensionConstants';
 import formatError from './utils/formatError';
-import LegacyConnectionModel from './views/webview-app/connection-model/legacy-connection-model';
+import type LegacyConnectionModel from './views/webview-app/connection-model/legacy-connection-model';
+import type { SecretStorageLocationType } from './storage/storageController';
 import {
   StorageLocation,
-  SecretStorageLocationType,
   SecretStorageLocation,
 } from './storage/storageController';
-import { StorageController, StorageVariables } from './storage';
-import { StatusView } from './views';
-import TelemetryService from './telemetry/telemetryService';
+import type { StorageController } from './storage';
+import { StorageVariables } from './storage';
+import type { StatusView } from './views';
+import type TelemetryService from './telemetry/telemetryService';
 import LINKS from './utils/links';
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const packageJSON = require('../package.json');

src/editors/activeConnectionCodeLensProvider.ts

@@ -1,7 +1,7 @@
 import * as vscode from 'vscode';
-import { TextEditor } from 'vscode';
+import type { TextEditor } from 'vscode';
 import EXTENSION_COMMANDS from '../commands';
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 import { isPlayground } from '../utils/playground';
 
 export default class ActiveConnectionCodeLensProvider

src/editors/collectionDocumentsCodeLensProvider.ts

@@ -2,7 +2,7 @@ import { URLSearchParams } from 'url';
 import * as vscode from 'vscode';
 import EXTENSION_COMMANDS from '../commands';
 
-import CollectionDocumentsOperationStore from './collectionDocumentsOperationsStore';
+import type CollectionDocumentsOperationStore from './collectionDocumentsOperationsStore';
 import {
   CONNECTION_ID_URI_IDENTIFIER,
   NAMESPACE_URI_IDENTIFIER,

src/editors/collectionDocumentsProvider.ts

@@ -1,11 +1,11 @@
 import * as vscode from 'vscode';
 import { URLSearchParams } from 'url';
 
-import CollectionDocumentsOperationsStore from './collectionDocumentsOperationsStore';
-import ConnectionController from '../connectionController';
-import EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
+import type CollectionDocumentsOperationsStore from './collectionDocumentsOperationsStore';
+import type ConnectionController from '../connectionController';
+import type EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
 import formatError from '../utils/formatError';
-import { StatusView } from '../views';
+import type { StatusView } from '../views';
 
 export const NAMESPACE_URI_IDENTIFIER = 'namespace';
 export const OPERATION_ID_URI_IDENTIFIER = 'operationId';

src/editors/editDocumentCodeLensProvider.ts

@@ -2,7 +2,7 @@ import * as vscode from 'vscode';
 import { EJSON } from 'bson';
 import type { Document } from 'bson';
 
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 import { DocumentSource } from '../documentSource';
 import type { EditDocumentInfo } from '../types/editDocumentInfoType';
 import EXTENSION_COMMANDS from '../commands';

src/editors/editorsController.ts

@@ -2,11 +2,11 @@ import * as vscode from 'vscode';
 import { EJSON } from 'bson';
 import type { Document } from 'bson';
 
-import ActiveConnectionCodeLensProvider from './activeConnectionCodeLensProvider';
-import ExportToLanguageCodeLensProvider from './exportToLanguageCodeLensProvider';
+import type ActiveConnectionCodeLensProvider from './activeConnectionCodeLensProvider';
+import type ExportToLanguageCodeLensProvider from './exportToLanguageCodeLensProvider';
 import PlaygroundSelectedCodeActionProvider from './playgroundSelectedCodeActionProvider';
 import PlaygroundDiagnosticsCodeActionProvider from './playgroundDiagnosticsCodeActionProvider';
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 import CollectionDocumentsCodeLensProvider from './collectionDocumentsCodeLensProvider';
 import CollectionDocumentsOperationsStore from './collectionDocumentsOperationsStore';
 import CollectionDocumentsProvider, {
@@ -17,8 +17,8 @@ import CollectionDocumentsProvider, {
 } from './collectionDocumentsProvider';
 import { createLogger } from '../logging';
 import DocumentIdStore from './documentIdStore';
-import { DocumentSource } from '../documentSource';
-import EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
+import type { DocumentSource } from '../documentSource';
+import type EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
 import type { EditDocumentInfo } from '../types/editDocumentInfoType';
 import formatError from '../utils/formatError';
 import { MemoryFileSystemProvider } from './memoryFileSystemProvider';
@@ -27,12 +27,11 @@ import MongoDBDocumentService, {
   DOCUMENT_SOURCE_URI_IDENTIFIER,
   VIEW_DOCUMENT_SCHEME,
 } from './mongoDBDocumentService';
-import PlaygroundController from './playgroundController';
-import PlaygroundResultProvider, {
-  PLAYGROUND_RESULT_SCHEME,
-} from './playgroundResultProvider';
+import type PlaygroundController from './playgroundController';
+import type PlaygroundResultProvider from './playgroundResultProvider';
+import { PLAYGROUND_RESULT_SCHEME } from './playgroundResultProvider';
 import { StatusView } from '../views';
-import TelemetryService from '../telemetry/telemetryService';
+import type TelemetryService from '../telemetry/telemetryService';
 
 const log = createLogger('editors controller');
 

src/editors/exportToLanguageCodeLensProvider.ts

@@ -1,9 +1,9 @@
 import * as vscode from 'vscode';
 
 import EXTENSION_COMMANDS from '../commands';
+import type { ExportToLanguageAddons } from '../types/playgroundType';
 import {
   ExportToLanguageMode,
-  ExportToLanguageAddons,
   ExportToLanguages,
 } from '../types/playgroundType';
 

src/editors/mongoDBDocumentService.ts

@@ -1,14 +1,14 @@
-import * as vscode from 'vscode';
+import type * as vscode from 'vscode';
 import { EJSON } from 'bson';
 import type { Document } from 'bson';
 
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 import { createLogger } from '../logging';
 import { DocumentSource } from '../documentSource';
 import type { EditDocumentInfo } from '../types/editDocumentInfoType';
 import formatError from '../utils/formatError';
-import { StatusView } from '../views';
-import TelemetryService from '../telemetry/telemetryService';
+import type { StatusView } from '../views';
+import type TelemetryService from '../telemetry/telemetryService';
 
 const log = createLogger('document controller');
 

src/editors/playgroundController.ts

@@ -1,41 +1,43 @@
 import * as vscode from 'vscode';
 import path from 'path';
-import { OutputChannel, ProgressLocation, TextEditor } from 'vscode';
+import type { OutputChannel, TextEditor } from 'vscode';
+import { ProgressLocation } from 'vscode';
 import vm from 'vm';
 import os from 'os';
 import transpiler from 'bson-transpilers';
 
-import ActiveConnectionCodeLensProvider from './activeConnectionCodeLensProvider';
-import PlaygroundSelectedCodeActionProvider from './playgroundSelectedCodeActionProvider';
-import ConnectionController, {
-  DataServiceEventTypes,
-} from '../connectionController';
+import type ActiveConnectionCodeLensProvider from './activeConnectionCodeLensProvider';
+import type PlaygroundSelectedCodeActionProvider from './playgroundSelectedCodeActionProvider';
+import type ConnectionController from '../connectionController';
+import { DataServiceEventTypes } from '../connectionController';
 import { createLogger } from '../logging';
-import { ConnectionTreeItem, DatabaseTreeItem } from '../explorer';
-import ExportToLanguageCodeLensProvider from './exportToLanguageCodeLensProvider';
+import type { ConnectionTreeItem } from '../explorer';
+import { DatabaseTreeItem } from '../explorer';
+import type ExportToLanguageCodeLensProvider from './exportToLanguageCodeLensProvider';
 import formatError from '../utils/formatError';
-import { LanguageServerController } from '../language';
+import type { LanguageServerController } from '../language';
 import playgroundCreateIndexTemplate from '../templates/playgroundCreateIndexTemplate';
 import playgroundCreateCollectionTemplate from '../templates/playgroundCreateCollectionTemplate';
 import playgroundCloneDocumentTemplate from '../templates/playgroundCloneDocumentTemplate';
 import playgroundInsertDocumentTemplate from '../templates/playgroundInsertDocumentTemplate';
-import {
+import type {
   PlaygroundResult,
   ShellEvaluateResult,
   ExportToLanguageAddons,
   ExportToLanguageNamespace,
-  ExportToLanguageMode,
   ThisDiagnosticFix,
   AllDiagnosticFixes,
 } from '../types/playgroundType';
-import PlaygroundResultProvider, {
+import { ExportToLanguageMode } from '../types/playgroundType';
+import type PlaygroundResultProvider from './playgroundResultProvider';
+import {
   PLAYGROUND_RESULT_SCHEME,
   PLAYGROUND_RESULT_URI,
 } from './playgroundResultProvider';
 import playgroundSearchTemplate from '../templates/playgroundSearchTemplate';
 import playgroundTemplate from '../templates/playgroundTemplate';
-import { StatusView } from '../views';
-import TelemetryService from '../telemetry/telemetryService';
+import type { StatusView } from '../views';
+import type TelemetryService from '../telemetry/telemetryService';
 import {
   isPlayground,
   getPlaygroundExtensionForTelemetry,

src/editors/playgroundResultProvider.ts

@@ -1,8 +1,9 @@
 import * as vscode from 'vscode';
 
-import ConnectionController from '../connectionController';
-import EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
-import { PlaygroundResult, ExportToLanguages } from '../types/playgroundType';
+import type ConnectionController from '../connectionController';
+import type EditDocumentCodeLensProvider from './editDocumentCodeLensProvider';
+import type { PlaygroundResult } from '../types/playgroundType';
+import { ExportToLanguages } from '../types/playgroundType';
 
 export const PLAYGROUND_RESULT_SCHEME = 'PLAYGROUND_RESULT_SCHEME';
 

src/editors/playgroundSelectedCodeActionProvider.ts

@@ -1,5 +1,5 @@
 import * as vscode from 'vscode';
-import { TextEditor } from 'vscode';
+import type { TextEditor } from 'vscode';
 
 import EXTENSION_COMMANDS from '../commands';
 import { ExportToLanguageMode } from '../types/playgroundType';

src/explorer/collectionTreeItem.ts

@@ -9,7 +9,7 @@ import DocumentListTreeItem, {
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
 import IndexListTreeItem from './indexListTreeItem';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 import SchemaTreeItem from './schemaTreeItem';
 
 function getIconPath(

src/explorer/connectionTreeItem.ts

@@ -2,10 +2,10 @@ import * as vscode from 'vscode';
 import path from 'path';
 
 import DatabaseTreeItem from './databaseTreeItem';
-import ConnectionController from '../connectionController';
+import type ConnectionController from '../connectionController';
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 
 export enum ConnectionItemContextValues {
   disconnected = 'disconnectedConnectionTreeItem',

src/explorer/databaseTreeItem.ts

@@ -6,7 +6,7 @@ import CollectionTreeItem from './collectionTreeItem';
 import type { CollectionDetailsType } from './collectionTreeItem';
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 
 function getIconPath(): { light: string; dark: string } {
   const LIGHT = path.join(getImagesPath(), 'light');

src/explorer/documentListTreeItem.ts

@@ -6,7 +6,7 @@ import { createLogger } from '../logging';
 import DocumentTreeItem from './documentTreeItem';
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 import type { DataService } from 'mongodb-data-service';
 
 const log = createLogger('documents tree item');

src/explorer/explorerController.ts

@@ -1,8 +1,7 @@
 import * as vscode from 'vscode';
 
-import ConnectionController, {
-  DataServiceEventTypes,
-} from '../connectionController';
+import type ConnectionController from '../connectionController';
+import { DataServiceEventTypes } from '../connectionController';
 import ExplorerTreeController from './explorerTreeController';
 
 export default class ExplorerController {

src/explorer/explorerTreeController.ts

@@ -1,9 +1,8 @@
 import * as vscode from 'vscode';
 
-import ConnectionController, {
-  DataServiceEventTypes,
-  StoreConnectionInfo,
-} from '../connectionController';
+import type { StoreConnectionInfo } from '../connectionController';
+import type ConnectionController from '../connectionController';
+import { DataServiceEventTypes } from '../connectionController';
 import ConnectionTreeItem from './connectionTreeItem';
 import { createLogger } from '../logging';
 import { DOCUMENT_ITEM } from './documentTreeItem';

src/explorer/fieldTreeItem.ts

@@ -2,7 +2,7 @@ import * as vscode from 'vscode';
 import path from 'path';
 
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 
 // Loosely based on bson types. These values match with the
 // types returned by `parseSchema` with `mongodb-schema`.

src/explorer/helpExplorer.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 import HelpTree from './helpTree';
-import { TelemetryService } from '../telemetry';
+import type { TelemetryService } from '../telemetry';
 
 export default class HelpExplorer {
   _treeController: HelpTree;

src/explorer/helpTree.ts

@@ -1,7 +1,7 @@
 import * as vscode from 'vscode';
 import path from 'path';
 import { getImagesPath } from '../extensionConstants';
-import { TelemetryService } from '../telemetry';
+import type { TelemetryService } from '../telemetry';
 import { openLink } from '../utils/linkHelper';
 import LINKS from '../utils/links';
 

src/explorer/indexListTreeItem.ts

@@ -1,12 +1,13 @@
 import * as vscode from 'vscode';
-import { DataService } from 'mongodb-data-service';
+import type { DataService } from 'mongodb-data-service';
 import path from 'path';
 
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
-import IndexTreeItem, { IndexModel } from './indexTreeItem';
+import type { IndexModel } from './indexTreeItem';
+import IndexTreeItem from './indexTreeItem';
 import { sortTreeItemsByLabel } from './treeItemUtils';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 
 const ITEM_LABEL = 'Indexes';
 

src/explorer/indexTreeItem.ts

@@ -2,7 +2,7 @@ import * as vscode from 'vscode';
 import path from 'path';
 
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 
 export enum IndexKeyType {
   ASCENDING = 1,

src/explorer/playgroundsTreeHeader.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
-import TreeItemParent from './treeItemParentInterface';
-import PlaygroundsTreeItem from './playgroundsTreeItem';
+import type TreeItemParent from './treeItemParentInterface';
+import type PlaygroundsTreeItem from './playgroundsTreeItem';
 import { sortTreeItemsByLabel } from './treeItemUtils';
 
 export default class PlaygroundsTreeHeader

src/explorer/schemaTreeItem.ts

@@ -6,9 +6,9 @@ import { createLogger } from '../logging';
 import FieldTreeItem from './fieldTreeItem';
 import formatError from '../utils/formatError';
 import { getImagesPath } from '../extensionConstants';
-import TreeItemParent from './treeItemParentInterface';
+import type TreeItemParent from './treeItemParentInterface';
 import { MAX_DOCUMENTS_VISIBLE } from './documentListTreeItem';
-import { DataService } from 'mongodb-data-service';
+import type { DataService } from 'mongodb-data-service';
 
 const log = createLogger('schema tree item');
 

src/explorer/treeItemParentInterface.ts

@@ -1,4 +1,4 @@
-import * as vscode from 'vscode';
+import type * as vscode from 'vscode';
 
 export default interface TreeItemParentInterface extends vscode.TreeItem {
   isExpanded: boolean;