This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
fix(secondaries): fixes connection with secondary readPreference #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
suggested changes
Dec 14, 2017
| @@ -1337,4 +1337,104 @@ describe('ReplSet Read Preferences (mocks)', function() { | |||
| }); | |||
| } | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Can we please move this test to tests/unit, and use the ReplSetFixture to cut out a lot of the code dupe, and allow us to focus on the actual test conditions.
daprahamian
force-pushed
the
NODE-1089
branch
2 times, most recently
from
dc3b225 to
0f38d9e
Compare
Ensures that when readPreference is `secondary`, the `connect` event is not triggered until connection has been established with a secondary. Fixes NODE-1089
daprahamian
force-pushed
the
NODE-1089
branch
from
0f38d9e to
4bbdf6c
Compare
mbroadst
reviewed
Dec 15, 2017
|
|
||
| replSet.on('connect', server => { | ||
| let err; | ||
| try { |
There was a problem hiding this comment.
do we actually need this try/catch? if the assertion fails we will still get the message during the test run (e.g. I think there is already a try/catch internal to mocha that provides this same behavior)
There was a problem hiding this comment.
since it is asynchronous, it won't work
mbroadst
approved these changes
Dec 15, 2017
jlord
approved these changes
Dec 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that when readPreference is
secondary, theconnectevent is not triggered until connection has been established
with a secondary.
Fixes NODE-1089