Updated require for electron app.

[Vj3k0]

Fixing failure with electron 1.0.0

---

This change is

[mention-bot]

By analyzing the blame information on this pull request, we identified @imlucas and @kangas to be potential reviewers

[Vj3k0]

Really? Hmm, I got electron error saying that it is not valid electron application. When I did this change, everything worked.
Which version of electron did you use?

[mitchhentges]

Confirmed, also not working for me unless this PR is merged. Seems to be related to Electron 1.0.0+ removing deprecated usage, and app has to be pulled off of require('electron'), now, instead of in it's own require('app').

See the docs here

[jbleuzen]

@Vj3k0 I was meaning that your fork was working.
I'm using it until it's merged...

[develar]

@imlucas Please apply this PR ASAP, because your module is recommended by electron-builder/windows-installeer and widely used. Please accept PR.

[mitchhentges]

Hey all, I've forked this to support electron@^1.0.0, and published the fork to npm under the name electric-squirrel.

Thanks again to Vj3k0 for the fix!
See the details here

[aaleks]

+1

[develar]

@imlucas If you don't have time, just add me to contributor (+ npm) (I maintainer of electron-builder, so, unlikely I will harm ;)) I really don't want to reinvent the wheel and promote @mitchhentges fork :)

In the future will be cool to move this project to electron-userland org.

[develar]

BTW electron-builder has own fork of Squirrel.Windows, so, in the future, electron-userland/electron-builder#409 may be implemented, and such module will be not required (yeah, so easy to create os x app, and so many troubles under windows...).

[imlucas]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[imlucas]

published in [email protected]

[develar]

@imlucas Thanks! Maybe it is time to publish it as 1.0.0? Because ^0.1.0 will not cover 0.2. I think there are no planned breaking changes and, so, 1.0.0 can be used.

[imlucas]

@develar agreed. published [email protected]

[imlucas]

@develar added as a contributor

[Vj3k0]

Thanks a lot! Cheers