Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-bar): retain current query when new query is applied COMPASS-8262 #6649

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Jan 23, 2025

We made following changes when autocompleting saved queries in query bar:

  1. When autocompleting on filter, user will see all the query (with other fields - sort, project etc) and once selected, whole query will be applied
  2. When autocompleting other fields -sort, project, collation, hint, we will only show those fields from the saved queries. And once applied, it will reflect changes only in that input.
Demo
Screen.Recording.2025-01-23.at.20.57.27.mov

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jan 23, 2025
@mabaasit mabaasit marked this pull request as ready for review January 23, 2025 20:11
@mabaasit mabaasit changed the title feat(query-bar): retain current query when new query is applied COMPASS-8262 fix(query-bar): retain current query when new query is applied COMPASS-8262 Jan 23, 2025
@mabaasit mabaasit added bug and removed feat labels Jan 23, 2025
@github-actions github-actions bot added the fix label Jan 23, 2025
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left two thoughts/small suggestions, and one main comment on performance I think we might want to consider.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice

@mabaasit mabaasit merged commit fa77bbb into main Jan 27, 2025
32 checks passed
@mabaasit mabaasit deleted the COMPASS-8262-retain-query branch January 27, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants