chore(e2e): throw if we're unexpectedly building Compass COMPASS-8615 #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Jan 15, 2025
| @@ -949,18 +949,20 @@ async function getCompassBuildMetadata(): Promise<BinPathOptions> { | |||
| } | |||
|
|
|||
| export async function buildCompass( | |||
| force = false, | |||
There was a problem hiding this comment.
drive-by, but we never use this
lerouxb
commented
Jan 15, 2025
| @@ -949,18 +949,20 @@ async function getCompassBuildMetadata(): Promise<BinPathOptions> { | |||
| } | |||
|
|
|||
| export async function buildCompass( | |||
| force = false, | |||
| compassPath = COMPASS_DESKTOP_PATH | |||
There was a problem hiding this comment.
yes the second parameter became the first, but we never pass either of these parameters, so that didn't require other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is here to make very sure that we're definitely testing the packaged app when we intend to. Mostly to not trip me up every time I read over that code.