-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): smoketest macOS .dmg files COMPASS-8709 #6582
Merged
Merged
+218
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
no release notes
Fix or feature not for release notes
feat
and removed
feat
labels
Dec 27, 2024
lerouxb
commented
Dec 27, 2024
{ | ||
name: 'smoketest-macos-x64', | ||
display_name: 'Smoketest MacOS Intel', | ||
run_on: 'macos-14-gui', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof. I missed -gui when I first mapped this out and didn't notice for days.
lerouxb
commented
Dec 27, 2024
lerouxb
commented
Dec 27, 2024
appInfo = await installMacDMG(buildInfo.productName, pkg); | ||
} | ||
|
||
// TODO: all the other installers go here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ie. the other sub-task tickets in this same story.
alenakhineika
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6579
COMPASS-8709
Installs the .app found in the .dmg to /Applications then runs the time to first query test on the app in /Applications.
To run locally: