chore(deps): update electron/rebuild dependency #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Oct 23, 2024
gribnoysup
commented
Oct 24, 2024
There was a problem hiding this comment.
It would probably be better for this to be in hadron-build to avoid logic duplication, but I'm a bit hesitant to add another cli script there and the amount of code it adds is small enough and pretty straightforward, we can move this later when we're cleaning up and renaming the package maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason after updating node-gyp the build that was passing in #6390 started failing on main, from the logs it seems that the culprit is a dependency on older node-gyp version in electron rebuild. Unclear to me why this didn't show up in the PR branch, so I'm just bumping the version of @electron/rebuild to resolve it (seems like they forked node-gyp to resolve the issue)