chore: bump the major version we run unit tests on in ci #6378
Conversation
lerouxb
force-pushed
the
bump-unit-test-mongodb-version
branch
from
5ee7063 to
fc55a01
Compare
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| export MONGODB_DEFAULT_VERSION=6.0.x | |||
| export MONGODB_DEFAULT_VERSION=7.0.x | |||
There was a problem hiding this comment.
I'm thinking we should probably not set this here and use it in print-compass-env.js and then somehow rather fill in a default if nothing is set in the compass tests. That would be the only way to have a consistent default locally and in CI because we don't use this file when just doing npm test locally.
| @@ -252,8 +252,10 @@ describe('connectMongoClient', function () { | |||
| expect(error).to.be.instanceOf(Error); | |||
|
|
|||
| // propagates the tunnel error | |||
| expect(error.message).to.match( | |||
| /(All configured authentication methods failed|ENOTFOUND compass-tests\.fakehost\.localhost)/ | |||
| // NOTE: this heavily depends on which server version we're running on | |||
There was a problem hiding this comment.
do we have to test for a specific message? can't we just confirm an error?
There was a problem hiding this comment.
I don't know. I didn't write the original test and I don't want to unnecessarily change the intention.
There was a problem hiding this comment.
or, if we want to test the propagation, is there a way to mock the server error?
There was a problem hiding this comment.
Yes, but this file is an integration test, not a unit test.
We were running unit tests on 6.0.x in CI and whatever mongodb-runner uses by default locally.