chore(atlas-service, indexes): remove all the domain specific parts of automation agent request helper #6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f automation agent request helper
This was referenced Sep 30, 2024
lerouxb
approved these changes
Oct 1, 2024
gribnoysup
deleted the
split-automation-agent-to-smaller-more-generic-parts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6290 (comment), we don't want any domain specific logic in atlas service, this means that there is a bit more similar code for handling responses that will be copied between rolling indexes and global sharding, but it's only two services for now, so it's not that big of a deal and keeps the atlas service more abstract