feat(connection-form): support for multiple kms options from same provider COMPASS-8082 #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Aug 29, 2024
packages/compass-connections/src/stores/connections-store-redux.ts
Outdated
Show resolved
Hide resolved
...ages/connection-form/src/components/advanced-options-tabs/csfle-tab/kms-provider-content.tsx
Outdated
Show resolved
Hide resolved
…PASS-8082-multiple-kms-providers
mabaasit
commented
Sep 6, 2024
Comment on lines
+175
to
+181
| if (isAction<CloseAction>(action, CreateNamespaceActionTypes.Close)) { | ||
| // When a modal is closed, we should not clear the connectionMetaData | ||
| return { | ||
| ...INITIAL_STATE, | ||
| connectionMetaData: state.connectionMetaData, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Drive-by: when opening modal to create a collection after closing it first time, the UI did not show encryption options, because we set connectionMetaData to initial state ({}).
…PASS-8082-multiple-kms-providers
mabaasit
force-pushed
the
COMPASS-8082-multiple-kms-providers
branch
from
b1e0b6b to
188bfaf
Compare
addaleax
reviewed
Sep 6, 2024
packages/connection-form/src/components/advanced-options-tabs/csfle-tab/csfle-tab.spec.tsx
Outdated
Show resolved
Hide resolved
packages/connection-form/src/components/advanced-options-tabs/csfle-tab/csfle-tab.tsx
Outdated
Show resolved
Hide resolved
packages/connection-form/src/components/advanced-options-tabs/csfle-tab/kms-provider-card.tsx
Outdated
Show resolved
Hide resolved
packages/connection-form/src/components/advanced-options-tabs/csfle-tab/kms-provider-card.tsx
Outdated
Show resolved
Hide resolved
...ages/connection-form/src/components/advanced-options-tabs/csfle-tab/kms-provider-content.tsx
Outdated
Show resolved
Hide resolved
...ages/connection-form/src/components/advanced-options-tabs/csfle-tab/kms-provider-content.tsx
Outdated
Show resolved
Hide resolved
| return Object.fromEntries( | ||
| Object.entries(obj).filter(([, value]) => Object.keys(value).length > 0) | ||
| ) as Partial<T>; | ||
| ); | ||
| } |
There was a problem hiding this comment.
This just removes the return type annotation and reduces type safety overall – any particular reason for that?
There was a problem hiding this comment.
this i reverted and added annotation back in 31d9e6f
There was a problem hiding this comment.
I mean the return type annotation is still missing but that's not a big deal
mabaasit
force-pushed
the
COMPASS-8082-multiple-kms-providers
branch
from
b2fe096 to
328a7c1
Compare
addaleax
reviewed
Sep 9, 2024
| noTLS={noTLS} | ||
| /> | ||
| </Card> | ||
| ); |
There was a problem hiding this comment.
Just wanted to say, I tried this out locally and it all feels very smooth and intuitive! This is amazing work ✨
addaleax
approved these changes
Sep 9, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes