Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compass): display warning message to user when Compass cannot access credential storage COMPASS-7819 #6056

Merged
merged 4 commits into from
Jul 26, 2024
Merged

feat(compass): display warning message to user when Compass cannot access credential storage COMPASS-7819 #6056

merged 4 commits into from
Jul 26, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jul 23, 2024 •
edited
Loading

Description

Use Electron's safeStorage.isEncryptionAvailable() to check if the secret storage works. If not, display a toast with a warning message.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jul 23, 2024
@alenakhineika alenakhineika requested a review from Anemy July 25, 2024 10:51
Anemy
Anemy reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one mention of a possible issue for isEncryptionAvailable which we might want to at least call out in a comment.
Other than that lgtm!

packages/compass/src/main/application.ts Show resolved Hide resolved
@alenakhineika alenakhineika requested a review from Anemy July 25, 2024 15:51
Anemy
Anemy approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one suggestion, not a blocker.

packages/compass/src/main/application.ts Show resolved Hide resolved
@alenakhineika alenakhineika changed the title feat: display warning message to user when Compass cannot access cred… feat(compass): display warning message to user when Compass cannot access cred… Jul 26, 2024
@alenakhineika alenakhineika merged commit 5d039d3 into main Jul 26, 2024
31 checks passed
@alenakhineika alenakhineika deleted the COMPASS-7819-warn-when-secret-storage-not-available branch July 26, 2024 09:25
@alenakhineika alenakhineika changed the title feat(compass): display warning message to user when Compass cannot access cred… feat(compass): display warning message to user when Compass cannot access credential storage COMPASS-7819 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
feat release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @Anemy