chore: attempt to make tab closing less flaky #6029
Conversation
| .$(Selectors.workspaceTab(selectorOptions)) | ||
| .$(Selectors.CloseWorkspaceTab) | ||
| .click(); | ||
| await browser.clickVisible( |
There was a problem hiding this comment.
clickVisible does some more waiting/checks
| const id = await currentActiveTab.getAttribute('id'); | ||
| await closeTab(browser, { id }, autoConfirmTabClose); | ||
| } | ||
| await browser.waitUntil(async () => { |
There was a problem hiding this comment.
waitUntil is the better way to poll/repeat than a tight loop. Takes into account proper timeouts.
| const currentActiveTab = await browser.$( | ||
| Selectors.workspaceTab({ active: true }) | ||
| ); | ||
| await currentActiveTab.click(); |
There was a problem hiding this comment.
Don't think this click was doing anything because the tab's already active.
There was a problem hiding this comment.
I think when I wrote it, the close button would only show up when the tab header was focused, but not when it's just active, it might've been a bug that we fixed at some point
There was a problem hiding this comment.
I also changed this significantly a few days ago which is likely why it started flaking again and also I could have just missed this.
| const currentActiveTab = await browser.$( | ||
| Selectors.workspaceTab({ active: true }) | ||
| ); | ||
| await currentActiveTab.click(); |
There was a problem hiding this comment.
I think when I wrote it, the close button would only show up when the tab header was focused, but not when it's just active, it might've been a bug that we fixed at some point
No description provided.