chore(e2e): add test for add connection failures COMPASS-8009 COMPASS-8091 #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Jul 16, 2024
| ...cloneDeep(connectionInfo), | ||
| }).then(() => setIsConnectionFormOpen(false)); | ||
| setIsConnectionFormOpen(false); | ||
| void _onConnect(connectionInfo).then(() => { |
There was a problem hiding this comment.
We weren't using all the same code for new connections as when connecting to existing saved connections which meant that errors weren't caught and the toast didn't appear.
lerouxb
commented
Jul 16, 2024
| @@ -299,6 +300,29 @@ describe('Connection string', function () { | |||
| } | |||
| }); | |||
|
|
|||
| it('fails for authentication errors', async function () { | |||
There was a problem hiding this comment.
We didn't actually have any tests for failed connections except in auto-connect.test.ts for connecting from the CLI, so we didn't notice before that the toast never showed up.
packages/compass-e2e-tests/helpers/commands/connect-with-connection-string.ts
Outdated
Show resolved
Hide resolved
packages/compass-e2e-tests/helpers/commands/wait-for-connection-result.ts
Outdated
Show resolved
Hide resolved
lerouxb
force-pushed
the
e2e-multiple-errors
branch
from
1c14d33 to
ca7033c
Compare
lerouxb
force-pushed
the
e2e-multiple-errors
branch
from
ca7033c to
56e0deb
Compare
paula-stacho
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also when adding a connection and it fails to connect the toast now shows up.