chore(gen-ai): remove strict validation of query response for aggregation generation #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current query response validation in Compass strictly checks for if a query exists in the response:
compass/packages/compass-generative-ai/src/atlas-ai-service.ts
Line 270 in 2d41950
The changes in https://github.com/10gen/mms/pull/98900 made it so that we don't return a query if no query fields were returned. Because of this change we now error in the validation when an aggregation is returned:
Cloud pr where we fix this: https://github.com/10gen/mms/pull/100505
We missed this as the ai-accuracy-tests do not do this same validation. This pr updates our validation in our accuracy tests to use what we do in our code flow. It also makes the check less strict.