Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-service): expose close event VSCODE-536 #5849

Merged
merged 6 commits into from
Jun 4, 2024
Merged

feat(data-service): expose close event VSCODE-536 #5849

merged 6 commits into from
Jun 4, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented May 28, 2024 •
edited
Loading

Description

Expose the close so we can listen on it in VSCode.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from addaleax May 28, 2024 10:12
@github-actions github-actions bot added the feat label May 28, 2024
@alenakhineika alenakhineika added the no release notes Fix or feature not for release notes label May 28, 2024
@alenakhineika alenakhineika changed the title feat(data-service): expose serverClosed event VSCODE-536 feat(data-service): expose close event VSCODE-536 May 28, 2024
@alenakhineika alenakhineika requested a review from addaleax June 3, 2024 18:35
@alenakhineika alenakhineika merged commit c2aa785 into main Jun 4, 2024
16 checks passed
@alenakhineika alenakhineika deleted the VSCODE-536-disconnect-when-server-closes branch June 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
feat no release notes Fix or feature not for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @addaleax