feat(compass-workspaces): adapt WorkspacePlugin to support tabs with multiple DataServices COMPASS-7718

[himanshusinghs]

Description

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[paula-stacho]

aren't connectionInfoId and connectionId the same thing?

[himanshusinghs]

aren't connectionInfoId and connectionId the same thing?

yeap they are the same - I renamed just now the instances of connectionInfoId to connectionId in this PR. There are a few more instances of this but those are from old PRs, I will rename them at a later point.

[himanshusinghs]

Besides the points I mentioned there is one other point I need to confirm which are the changes for compass-web. In its current state the CompassWeb tab router does not add ConnectionInfo to the returned WorkspaceOptions. There are two ways to approach it:

• make ConnectionId part of URL path so that it resolves alongside the workspace options but I am not able to fully understand what it would mean for mms
• silently add ConnectionId to the workspace options but this felt a bit hacky

So excluding this, the PR should be ready for review.

[paula-stacho]

@kmruiz do we already have a follow up task to fix the sidebar with the new activeWorkspace.connectionId? If we don't I can create it

[kmruiz]

@kmruiz do we already have a follow up task to fix the sidebar with the new activeWorkspace.connectionId? If we don't I can create it

I believe this was part of this task, but if we want to do it in another please feel free to create a ticket and we can play it when we merge this PR.

[himanshusinghs]

@paula-stacho All the usage of WorkspaceService already pass connectionId in this PR so that part is covered.

[paula-stacho]

Re @himanshusinghs and @kmruiz

ConnectionId is passed to the new sidebar, but it doesn't trickle all the way down to ConnectionsNavigationTree. So the highlighting and expanding behaviour of connection items isn't complete. We weren't sure what the new structure of Workspace will be, so we didn't prepare that part. I'd say it can easily be a follow up.

[kmruiz]

LGTM.

[kmruiz]

Re @himanshusinghs and @kmruiz

ConnectionId is passed to the new sidebar, but it doesn't trickle all the way down to ConnectionsNavigationTree. So the highlighting and expanding behaviour of connection items isn't complete. We weren't sure what the new structure of Workspace will be, so we didn't prepare that part. I'd say it can easily be a follow up.

Then please feel free to create a task, we can play it when we merge this PR. From what you say, when we merge this passing down the connection id should be pretty straightforward.

[paula-stacho]

Looks good!