Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): make scripts/logserver.js output pipeable #5089

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

baileympearson
Copy link
Contributor

Description

I found it useful to use jq to filter the output of the logserver, but the logserver currently logs with console.dir which is not parsable by jq. This PR auto-detects when the output of the script is piped writes the output accordingly. I also added colors for the non-jq use case.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

scripts/logserver.js Outdated Show resolved Hide resolved
@baileympearson baileympearson merged commit cb6335e into main Nov 10, 2023
5 checks passed
@baileympearson baileympearson deleted the no-story-improve-logserver-logs branch November 10, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants