This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
feat(NODE-3302): replace MAX_BSON_SIZE with "maxBSONSize" property #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions on overflow
|
Gentle reminder :) |
|
Hello, thank you for the reminder and apologies that we've not gotten back to you sooner, I've made NODE-3302 to track this on our JIRA, I'll add the team as reviewers but it may be until next week when we're able to get to triaging the issue. |
dariakp
changed the title
emadum
approved these changes
May 25, 2021
|
@jancurn As an aside, have you considered using our js-bson library instead of bson-ext? |
Yes we were using it, but were hopeful to use native BSON functionality for performance gains. |
drobnikj
pushed a commit
to drobnikj/bson-ext
that referenced
this pull request
Feb 16, 2023
…ongodb-js#65) (cherry picked from commit 0b59b67)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MAX_BSON_SIZEconstant and only usemaxBSONSizeproperty to enable variable BSON size - fixes https://github.com/mongodb-js/bson-ext/issues/42ThrowAllocatedStringException()so they can be correctly caught - fixes https://github.com/mongodb-js/bson-ext/issues/43NODE-3302