Fix API Functionality for MongoDB >=6.0 #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was depecrated in MongoDB 4.0. It's an unrecognized field as of MongoDB 6.0. https://github.com/mongodb/specifications/blob/e9f02f328a93d6a0321694cc30d031079c555e4a/source/crud/crud.md?plain=1#L681
The readPreference field is required to read from replicaSet secondaries.
When a batchSize is specified on a GetMore request to MongoDB its first response with the first batch of docs is returned at the top level instead of the expected cursor structure. It sometimes occurs even without the presence of a batchSize parameter in the request.
Re-write the MoreToCome response handling logic to use monadic loops instead of conduit streaming to yield GetMore responses. The conduit logic ends up swallowing responses into the abyss instead of producing and consolidating them as intended.
If nothing else, it simplifies the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now the OP_MSG message functionality is incomplete and/or breaking for Mongo server wire versions > 17. The changes made here restore expected behavior for APIs that broke between the migration from mongoDB version 5.0 to 6.0.
NOTE: EOL of MongoDB 5.0 is October 2024