ci: containerize depends jobs #9784
Merged
+93
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamamyth
reviewed
Feb 8, 2025
tobtoht
force-pushed
the
ci_depends_container
branch
from
4abee18 to
883d9bf
Compare
iamamyth
reviewed
Feb 9, 2025
tobtoht
force-pushed
the
ci_depends_container
branch
from
883d9bf to
bda0de0
Compare
iamamyth
approved these changes
Feb 9, 2025
tobtoht
force-pushed
the
ci_depends_container
branch
from
bda0de0 to
5b30213
Compare
selsta
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 10.0 does not recognize the
aarch64-apple-darwintarget. The release branch hacks around this by automatically renaming the target.This approach is less straightforward on master due to the introduction of CMake in depends. We would also need to inform CMake about the updated target to prevent it from passing
--target=aarch64-apple-darwinto the compiler.It's less messy to just rename the target to whatever clang expects.