🐛 fix contains on dict type
#5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are experiencing issues where two `dict` types being compared don't
come up with the right results. Here is an example I ran to produce
this:
```coffee
> region = terraform.plan.variables.where( name == "gcp_region" ).first.value;
terraform.plan.variables.where(name == "service_vpc_connector").all(v: v.value.contains(region) )
[failed] [].all()
actual: [
0: terraform.plan.variable value="projects/prj-pp-gen-preprod-net-acc7/locations/us-central1/connectors/preprod-gen-central1-02" name="service_vpc_connector"
]
```
As you can see above we are looking at the `value` of the varaible,
which clearly is set to the region but doesn't come up. If we print out
the variables individually, it all comes out correctly.
The problem is that the string comparison doesn't work when we work with
`dict` types because in that example we have to create code that has to
with with arbitrary content and work with filtering on another `dict`.
This PR fixes the issue.
```coffee
> region = terraform.plan.variables.where( name == "gcp_region" ).first.value;
terraform.plan.variables.where(name == "service_vpc_connector").all(v: v.value.contains(region) )
[ok] value: true
```
Signed-off-by: Dominik Richter <[email protected]>
Signed-off-by: Dominik Richter <[email protected]>
chris-rock
approved these changes
Jan 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing issues where two
dicttypes being compared don't come up with the right results. Here is an example I ran to produce this:As you can see above we are looking at the
valueof the varaible, which clearly is set to the region but doesn't come up. If we print out the variables individually, it all comes out correctly.The problem is that the string comparison doesn't work when we work with
dicttypes because in that example we have to create code that has to with with arbitrary content and work with filtering on anotherdict.This PR fixes the issue.
CC @scottford-io